Release of SLIM Java Starterkit Sample Project#5
Draft
jpl-jengelke wants to merge 3 commits intodevelopfrom
Draft
Release of SLIM Java Starterkit Sample Project#5jpl-jengelke wants to merge 3 commits intodevelopfrom
jpl-jengelke wants to merge 3 commits intodevelopfrom
Conversation
Collaborator
Author
|
Notification will be sent when converted from draft status. |
yunks128
reviewed
Dec 15, 2023
| { getent passwd ${UID} || useradd -u ${UID} -s /bin/sh -d ${HOME} -g ${GID} ${USR} ; } | ||
|
|
||
| # basic user environment -- includes jq, python and testrail reporter | ||
| RUN mkdir -p ${HOME} && chmod 777 ${HOME} && \ |
Collaborator
There was a problem hiding this comment.
Using chmod 777 on the user's home directory (${HOME}) might be too permissive.
How about chown instead?
chown -R ${USR}:${USR} ${HOME}
Collaborator
Author
There was a problem hiding this comment.
That's a great observation. It is running inside the container so I was assuming this was only affecting the mount inside the container. In this context, the container is only executed ephemerally and stops after the job completes. I definitely need to review some of this earlier stuff to tighten it up, so I will.
Please bear with me as there will be more content to review shortly. I've kept it in draft until it's ready for thorough review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Proposed Changes
parent-ammosPOMversionin the top-level of produced artifacts, such as JARs or WARsmainbranch.Issues
Testing